Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

db: avoid keyspanimpl.TableNewSpanIter closure allocation #3584

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jbowens
Copy link
Collaborator

@jbowens jbowens commented May 3, 2024

The tableNewIters func requires a context, but the keyspanimpl.TableNewSpanIter func used by keyspan.LevelIter did not take one. This required iterator construction to close over the context and the tableNewIters to create an keyspanimpl.TableNewSpanIter, forcing an allocation.

This commit refactors the keyspanimpl.LevelIter to embed a context, like the point iterator's levelIter, and propagate the context into TableNewSpanIter through an argument.

The tableNewIters func requires a context, but the keyspanimpl.TableNewSpanIter
func used by keyspan.LevelIter did not take one. This required iterator
construction to close over the context and the tableNewIters to create an
keyspanimpl.TableNewSpanIter, forcing an allocation.

This commit refactors the keyspanimpl.LevelIter to embed a context, like the
point iterator's levelIter, and propagate the context into TableNewSpanIter
through an argument.
@jbowens jbowens requested a review from a team as a code owner May 3, 2024 14:50
@jbowens jbowens requested a review from aadityasondhi May 3, 2024 14:50
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants